Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes QOBLIB metadata constants by creating a definitions module and refactoring multiple problem domain implementations to use shared constants instead of duplicated hardcoded values.
- Adds centralized constants for QOBLIB authors, license, and metadata in a new definitions module
- Refactors existing problem implementations to use shared constants instead of inline duplicated author lists
- Adds missing annotations to several problem domains (01, 07, 08, 09) to ensure consistent metadata
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ommx_quantum_benchmarks/qoblib/definitions.py | Introduces centralized QOBLIB constants including authors list, license, and Docker image metadata |
| ommx_quantum_benchmarks/qoblib/10_topology/models/seidel_quadratic/ommx_create.py | Replaces inline author list with shared constants and updates license reference |
| ommx_quantum_benchmarks/qoblib/10_topology/models/seidel_linear/ommx_create.py | Replaces inline author list with shared constants and updates license reference |
| ommx_quantum_benchmarks/qoblib/10_topology/models/flow_mip/ommx_create.py | Replaces inline author list with shared constants and updates license reference |
| ommx_quantum_benchmarks/qoblib/09_routing/models/integer_linear/ommx_create.py | Adds missing annotations using shared constants |
| ommx_quantum_benchmarks/qoblib/08_network/models/integer_lp/ommx_create.py | Adds missing annotations, refactors data formatting, and uses shared constants |
| ommx_quantum_benchmarks/qoblib/07_independentset/models/binary_unconstrained/ommx_create.py | Adds missing annotations using shared constants |
| ommx_quantum_benchmarks/qoblib/07_independentset/models/binary_linear/ommx_create.py | Adds missing annotations using shared constants |
| ommx_quantum_benchmarks/qoblib/01_marketsplit/models/binary_unconstrained/ommx_create.py | Adds missing annotations using shared constants |
| ommx_quantum_benchmarks/qoblib/01_marketsplit/models/binary_linear/ommx_create.py | Adds missing annotations using shared constants |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ommx_quantum_benchmarks/qoblib/08_network/models/integer_lp/ommx_create.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions
Add annotations to 01, 07, 08 and 09.